Closed Prakhar-Agarwal-byte closed 1 year ago
I think the difference in size is due to the icons in Prev and Next buttons. I will add some padding in the Finish button to fix this.
Yes something about the way the weight is distributed between the two buttons I think might be the cause. Somehow the "Prev" button keeps the same size across devices and the other button always just uses whatever space is left (not sure about this, just a feeling).
On my emulator it looks like this is not yet fixed. The buttons are closer in size, but not identical by default (and I don't think they're the same length).
I think the issue is that the fix in #300 is hard-coding a padding value, but that won't really fix the issue on all screen sizes.
My bad, totally forgot about padding potentially being different for all screen sizes.
There should be a few good alternative ways of solving this (both prev and next buttons using the same row and filling up height etc..)
Yeah agreed, I think the idea of the two buttons sharing a row and filling up the height + using each the same width proportion inside the row makes sense and will ensure they always just look the same.
The
Finish
button here is smaller than thePrev
andNext
buttons.We should make it the same size as the other buttons.