search

thunderbiscuit / padawan-wallet

The bitcoin wallet trainer on Android.
https://padawanwallet.com/
Apache License 2.0
111 stars 49 forks source link

Generating an address displays a different string for a moment #301

Closed thunderbiscuit closed 1 year ago

thunderbiscuit commented 1 year ago

I think this is a small snag introduced in #278.

The QR image displays the string "No address yet" for a split second while the actual first address is computed.

https://user-images.githubusercontent.com/39974688/231176470-ff084bf3-c20f-4acb-8987-f27da82c0b6d.mov

yellowHatpro commented 1 year ago

I am sorry but I didn't get the issue. Can you elaborate on how we know where is the "No address yet" displayed?

yellowHatpro commented 1 year ago

DId you mean the QR that was visible for a split second, when scanned, gives "No address yet" ?

thunderbiscuit commented 1 year ago

Yep exactly. It's the default string value for the address variable in the viewmodel, and so that's what's displayed first. I think we should just remove that and have no image displayed until the address is ready.

yellowHatpro commented 1 year ago

Oh ok, that looks like an ez fix, will make a pr soon