Closed geigerzaehler242 closed 7 months ago
Awesome! The unit tests are failing not because of this PR at all, so I'm diregarding them at the moment (will fix in a further PR).
This looks pretty good. I think all you'd need is to clean up the commit history. A few pointers:
separate-views
, and open a new PR with that onto my master; (b) squash all 4 commits into 1, which will clean up your unintentional old commits and the merge commit. You can then force push those changes to your branch, which will update your PR.Happy to help with any of those steps if you'd like a more detailed approach. Cheers!