search

thunderbug1 / LibreChatAzureDeployment

A Terraform setup to deploy LibreChat to Azure and setup all the necessary services.
MIT License
31 stars 24 forks source link

Improved the ability to configure Azure OpenAI deployments. #7

Closed ktooi closed 9 months ago

ktooi commented 9 months ago

Thank you for merging #6.

I wanted to deploy GPT-4 in Azure OpenAI, so I modified it.

If you have anything you want me to change, just ask and will do my best to accommodate such that it can be merged.

thunderbug1 commented 9 months ago

Thank you for merging #6.

I wanted to deploy GPT-4 in Azure OpenAI, so I modified it.

If you have anything you want me to change, just ask and will do my best to accommodate such that it can be merged.

Thank you for the PR. PRs are always welcome, right now I don't really have the time to do much development on the project but there are some configs that are unused at the moment, see https://github.com/thunderbug1/LibreChatAzureDeployment/issues/3 If you want to do some work, that might be a good place to start ;)

ktooi commented 9 months ago

Thank you for your confirmation and reply. Regarding the unused Config, are you referring to AZURE_OPENAI_API_COMPLETIONS_DEPLOYMENT_NAME and AZURE_OPENAI_API_EMBEDDINGS_DEPLOYMENT_NAME? I know these are not used, but I have fixed them for consistency.

This Terraform is important to me and I will continue to open PRs as needed 😄

thunderbug1 commented 9 months ago

No, I think that DOCKER_REGISTRY_SERVER_URL has no effect. It is not an issue but it may be confusing for people and potentially there are other unused parameters as well. I never found the time to tidy things up.