thunderclient / thunder-client-support

Thunder Client is a lightweight Rest API Client Extension for VS Code.
https://www.thunderclient.com
Other
3.61k stars 126 forks source link

GET request with "url=" parameter fails to prepend "Request Url" correctly #1500

Closed sh3llcmdr closed 5 months ago

sh3llcmdr commented 5 months ago

Describe the bug Thunder Client fails to prepend the "Request Url" with "http://" if the GET request includes a "url=" parameter which also has a "http://" prefix

To Reproduce In this instance I'm using a VM running VAPI (Vulnerable API) and redirecting to a public Burp Collaborator address to demonstrate. The request works perfectly if sent via Burp Suite, just for comparison.

Create a HTTP GET request with the "url=" parameter, adding the "http://" prefix to the URL and attempt to send: image Thunder Client will simply show an ERROR status in the response window image

Create a HTTP GET request with the "url=" parameter, without adding the "http://" prefix to the URL and attempt to send: image It will send but cause a "500 Server Error" as the "url=" parameter is not correctly formatted. image

Expected behavior Thunder Client should correctly prepend the "Request Url" with "http://" (or "https://") if the "url=" parameter also has "http://" or "https://" included

Platform:

Are you using the free version/paid version/trial: Free version

rangav commented 5 months ago

Hi @sh3llcmdr

you can encode the query param value

Screenshot 2024-03-12 at 11 56 50
sh3llcmdr commented 5 months ago

OK, good to know. That's not really obvious for the user, or should be done automatically.

Let me test that

sh3llcmdr commented 5 months ago

Yep that works. Thanks for the quick reply