Oauth says "Saved Successfully" when it fails

[awstlaur]

Describe the bug Generating an Oauth token gives the popup "Saved Successfully" with green text despite failing.

To Reproduce Under Auth -> Oauth2, send an oauth request with invalid credentials.

Observe the the success popup, but observe the following in the output:

OAuth2 Client Credentials Request: https://redacted.domain/oauth2/token
Request Method: POST
Request Headers:
{
  "Content-Type": "application/x-www-form-urlencoded"
}
Request Body:
grant_type=client_credentials&client_id=invalid_client_id&client_secret=invalid_client_secret

OAuth Response:
{
  "error_description": "Authorization failed. Invalid credentials",
  "error": "invalid_client"
}

Expected behavior I expect a failure popup

Platform:

• OS: macOS Sonoma 14.4.1
• vscode version: 1.89.0
• node version: 18.18.2
• extension version: v2.22.1

Are you using the free version/paid version/trial: Free