search

thundergolfer / example-bazel-monorepo

🌿💚 Example Bazel-ified monorepo, supporting Golang, Java, Python, Scala, and Typescript
https://buildkite.com/thundergolfer-inc/the-one-true-bazel-monorepo
MIT License
328 stars 33 forks source link

Register Buildbuddy #23

Closed thundergolfer closed 4 years ago

thundergolfer commented 4 years ago

Description

⚠️ Currently getting a blank white screen when hitting a build invocation page, eg. https://app.buildbuddy.io/invocation/93a9d34a-3dce-47f5-9770-59799ad9e65f

TypeError: Cannot read property 'buildEvent' of undefined

Update: The error appears to have gone now. I can see the BuildBuddy page

image

thundergolfer commented 4 years ago

cc @siggisim

thundergolfer commented 4 years ago

Had to revoke my Github Oauth tokens are having them in my environment and publishing them in a buildbuddy invocation URL 😖.

Might want to turn on --strict_env, and think twice before linking a Buildbuddy invocation URL publicly.

siggisim commented 4 years ago

Hey Jonathan - sorry about this. We're working on dropping environment variables for unauthenticated requests.

Will keep you posted when that's live.

thundergolfer commented 4 years ago

No worries, it was my mistake!

That feature sounds good though.