search

thundergolfer / example-bazel-monorepo

🌿💚 Example Bazel-ified monorepo, supporting Golang, Java, Python, Scala, and Typescript
https://buildkite.com/thundergolfer-inc/the-one-true-bazel-monorepo
MIT License
328 stars 33 forks source link

What is the point of bootstrap_agent.sh #50

Open smeyerhot opened 3 years ago

smeyerhot commented 3 years ago

Description of the problem / feature request:

It looks like bootstrap_agent.sh does just about nothing. What is the point of this script, and why do you have it in a s3 bucket?

🐛 Bug Report: Expected Behavior

🐛 Bug Report: Actual Behavior

🐛 Bug Report: Steps to Reproduce the Problem

1. 2. 3.

🐛 Bug Report: Specifications

thundergolfer commented 3 years ago

If you look through the history of that file, you'll see it used to install some stuff that I hadn't baked into the AWS AMI, such as the Black Python source code formatter.

Recently I removed the need to install anything, and so the file became a kind of 'no op', but the Buildkite config still expects to find and run that file, so it still exists.

In future I could just remove the config that has Buildkite expecting to run that file, and then remove the file.

smeyerhot commented 3 years ago

Ok, fair enough. Is the ami is for the buildkite agent?

thundergolfer commented 3 years ago

Yes the AMI is for the Buildkite agent. It's not a nice dev-loop to have to rebuild AMIs, but not bothered to change it for now.