search

thundergolfer / fast-links

Painlessly embed references into your online comments and posts. #FB-Hack2017 :2nd_place_medal:
MIT License
3 stars 0 forks source link

Facebook links are put in front of the entity #24

Open thundergolfer opened 7 years ago

thundergolfer commented 7 years ago

When linking things in Facebook, the link reference is put in front of the entity rather than after it. For example if this is your test case:

There is A Thing that comes from Japan land.

Where, "A Thing" is the entity. facebookLinkInsert() gives you this.

There is (2)A Thing that comes from Japan land. (2): A Thing - http://alinktoathing.com.au/athing

This is not great, as it looks almost like "There is" is the thing being referenced.

Should be an easy fix. The code is in entity_recognition.js.

avra-m3 commented 7 years ago

Assign this to whoever wrote the code (I'm guessing you), seems like an easy fix but I'm not confident I know what the code does.