Closed MythicManiac closed 6 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
b25120b
) 92.91% compared to head (7a20c67
) 92.93%.
Files | Patch % | Lines |
---|---|---|
django/thunderstore/schema_import/sync.py | 95.45% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why do we want to continue on exceptions, though?
Because the imported data is not relational to everything else in the file, meaning that if importing object A fails, importing object B can still be attempted. otherwise any error anywhere in the schema would block the entire process until someone fixes it. The entities in the schema could very well be their own documents each & can be processed as such, they're just in a single blob for convenience.
Add support for importing package installer definitions from the ecosystem schema.
Additionally, add some metadata fields to the PackageInstaller model which will be available in the ecosystem schema.