Versions of Mods - Githubissues

thunderstore-io / Thunderstore

Thunderstore is a mod database and API for downloading mods. Thunderstore Discord: https://discord.thunderstore.io/

https://thunderstore.io/

GNU Affero General Public License v3.0

127 stars 28 forks source link

Versions of Mods #128

Closed CMudeye closed 4 years ago

CMudeye commented 4 years ago

Currently, the upload page of thunderstore.io tells you to use semantic versioning: "version_number - Version number of the mod, following the semantic version format Major.Minor.Patch. For example: 1.3.2."

There is currently a mod with a version number of 20.08.210338 that does not follow this: https://thunderstore.io/package/Higgs1/Lighthouse/

I believe either the message about semantic versioning should be clarified or the version number should be validated.

MythicManiac commented 4 years ago

Related #123

I believe this is due to python's default version utils not caring about the leading zero, which obviously is incorrect. Example:

Python 3.8.0 (tags/v3.8.0:fa919fd, Oct 14 2019, 19:37:50) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from distutils.version import StrictVersion
>>> StrictVersion("20.08.210338")
StrictVersion ('20.8.210338')