search

thunderstore-io / Thunderstore

Thunderstore is a mod database and API for downloading mods. Thunderstore Discord: https://discord.thunderstore.io/
https://thunderstore.io/
GNU Affero General Public License v3.0
134 stars 27 forks source link

Update python to 3.12 #887

Open MythicManiac opened 1 year ago

MythicManiac commented 1 year ago

Update python to 3.12 along some dependencies which required updating at the same time.

At least a single issue seems to still be unresolved in kombu (used by celery), waiting on https://github.com/celery/kombu/issues/1668 to be resolved before this can be merged

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (71fd783) 92.18% compared to head (e322fd3) 91.31%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #887 +/- ## ========================================== - Coverage 92.18% 91.31% -0.87% ========================================== Files 270 270 Lines 7711 7531 -180 Branches 734 734 ========================================== - Hits 7108 6877 -231 Misses 501 501 - Partials 102 153 +51 ``` [see 180 files with indirect coverage changes](https://app.codecov.io/gh/thunderstore-io/Thunderstore/pull/887/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thunderstore-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anttimaki commented 1 year ago

@MythicManiac well code change wise LGTM, did you want me to test this locally?

MythicManiac commented 1 year ago

Not before the obvious issues are fixed (the kombu compatibility issue) at least, since we should do proper testing after the changes are fully locked in, so it'd potentially be wasted work at this point.