search

thunderstore-io / Thunderstore

Thunderstore is a mod database and API for downloading mods. Thunderstore Discord: https://discord.thunderstore.io/
https://thunderstore.io/
GNU Affero General Public License v3.0
138 stars 28 forks source link

Cyberstorm API: improve sorting on team-related list views #898

Closed anttimaki closed 1 year ago

anttimaki commented 1 year ago

Cyberstorm API: add tests for sorting team-related list views

Refs TS-1856

Cyberstorm API: use StrictOrderingFilter on team-related list views

Based on non-blocking review comment, Mythic has apparently had some issues with DRF's stock OrderingFilter, so use the home brewed StrictOrderingFilter instead.

Refs TS-1856

anttimaki commented 1 year ago

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (746252c) 92.27% compared to head (ba10602) 65.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #898 +/- ## =========================================== - Coverage 92.27% 65.30% -26.97% =========================================== Files 271 271 Lines 7820 7820 Branches 743 743 =========================================== - Hits 7216 5107 -2109 - Misses 502 2638 +2136 + Partials 102 75 -27 ``` | [Files](https://app.codecov.io/gh/thunderstore-io/Thunderstore/pull/898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thunderstore-io) | Coverage Δ | | |---|---|---| | [django/thunderstore/api/cyberstorm/views/team.py](https://app.codecov.io/gh/thunderstore-io/Thunderstore/pull/898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thunderstore-io#diff-ZGphbmdvL3RodW5kZXJzdG9yZS9hcGkvY3liZXJzdG9ybS92aWV3cy90ZWFtLnB5) | `75.67% <100.00%> (-24.33%)` | :arrow_down: | ... and [164 files with indirect coverage changes](https://app.codecov.io/gh/thunderstore-io/Thunderstore/pull/898/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thunderstore-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anttimaki commented 1 year ago

I've no idea what codecov is complaining about.