thunderstore-io / Thunderstore

Thunderstore is a mod database and API for downloading mods. Thunderstore Discord: https://discord.thunderstore.io/
https://thunderstore.io/
GNU Affero General Public License v3.0
128 stars 27 forks source link

[Feature Request] Prevent publishing of modpacks to games the mods are not from or for. #920

Closed Glendening closed 9 months ago

Glendening commented 9 months ago

Seen an uptick in mod packs for various games being posted to the mod list of H3VR. There should be some logic in the Thunderstore that prevents users from posing mod packs using mods from one mod to the list of mods for another. IG: a mod pack full of Lethal company mods can't be published as a Valheim modpack.

Examples: https://h3vr.thunderstore.io/package/SICKCOOLEPIC/epicsickcooltimesbutcooler/ https://h3vr.thunderstore.io/package/LethalSquad/TestMod/ https://h3vr.thunderstore.io/package/PrincePucci/Sillytimewithmygoodpals/ https://h3vr.thunderstore.io/package/Aroma_Monkeys/Romi_ModPack/ https://h3vr.thunderstore.io/package/Clownies/diaper/

MythicManiac commented 9 months ago

Thanks for opening the issue! This has indeed happened more frequently recently and there's been several instances of similar feedback about it.

I can't promise this to get addressed immediately, but I'll at least check if we can find a simple solution that covers most situations without incurring too much tech debt & prioritize getting that implemented if it seems reasonable.

There is a WIP branch with a report feature that should also help once finished, but that's been stalled recently due to the report processing portion not being figured out yet.

MythicManiac commented 9 months ago

925 should hopefully help with this issue, I'll close this once it's deployed but feel free to re-open if the problem persists.

MythicManiac commented 9 months ago

Closing this as #925 was merged and deployed, feel free to re-open if you still notice the same pattern continuing