thunderstore-io / Thunderstore

Thunderstore is a mod database and API for downloading mods. Thunderstore Discord: https://discord.thunderstore.io/
https://thunderstore.io/
GNU Affero General Public License v3.0
134 stars 27 forks source link

Fix odd issue with test state consistency #962

Closed MythicManiac closed 10 months ago

MythicManiac commented 10 months ago

Evidently some configurations of test run splitting will lead to a problem where a test starts off expecting a file to not exist in an S3 bucket, but it does. This problem does not occur if all tests are run.

This does not solve the root cause, but it does address the issue for the specific test which was failing.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (60a453f) 92.70% compared to head (5b48fd4) 85.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #962 +/- ## ========================================== - Coverage 92.70% 85.14% -7.57% ========================================== Files 283 283 Lines 8459 8459 Branches 786 786 ========================================== - Hits 7842 7202 -640 - Misses 510 1146 +636 - Partials 107 111 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.