thunderstore-io / Thunderstore

Thunderstore is a mod database and API for downloading mods. Thunderstore Discord: https://discord.thunderstore.io/
https://thunderstore.io/
GNU Affero General Public License v3.0
128 stars 27 forks source link

Stop implicit removal of categories #976

Closed MythicManiac closed 8 months ago

MythicManiac commented 8 months ago

Adjust the upload processing behavior to not implicitly remove existing categories from packages when a new version is uploaded. Many users re-select some categories when updating their package without realizing that any category not selected gets removed.

This commit changes the behavior so that category removals will never happen when mods are updated, which should reduce the amount of accidental category removals.

Categories can still be removed via the package management panel.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6e1ddfc) 93.00% compared to head (9c3b3ef) 93.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #976 +/- ## ======================================= Coverage 93.00% 93.00% ======================================= Files 287 287 Lines 8474 8474 Branches 760 760 ======================================= Hits 7881 7881 Misses 493 493 Partials 100 100 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.