Closed MythicManiac closed 8 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
874ab10
) 93.04% compared to head (4ff9c77
) 93.03%.
Files | Patch % | Lines |
---|---|---|
django/thunderstore/webhooks/models/audit.py | 37.50% | 3 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I was debating on creating a migration that creates a dedicated user for the "System user" so we can use the same flow for all events, but that quickly turned into a much more complex operation than what I had time to implement in the moment so this is what we have for now.
I do think we should do all permission checks through users and simply create a root user of some kind for system operations (fake or otherwise). Making it an actual user has some security implications though so it's probably best to keep it as a code-only accessible user.
Make the user field in audit events optional for logs produced by system events.