Closed MythicManiac closed 8 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
03da139
) 93.04% compared to head (88e2518
) 93.01%.
Files | Patch % | Lines |
---|---|---|
django/thunderstore/repository/package_upload.py | 20.00% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
That has to do with naming as the function names sort of imply they're performing a check of some kind, and it's intuitive for that check to return true if it passes IMO. Couldn't think of a non-verbose way to invert the naming so this is what we have this time
Include validation that ensures the zip file starts at offset 0 and that it includes no relative paths in the files.
In theory the zip files might still contain bogus data in the middle, but this is fairly unlikely to happen in practice and shouldn't impact the behavior of other applications.