thunkable / thunkable-issues

24 stars 9 forks source link

Icon Display with Maps #1088

Open KaneoheKid opened 2 years ago

KaneoheKid commented 2 years ago

Several issues with the new map icon feature. First, thanks for providing it, i really appreciate the feature.

All screenshots were taken from different devices running the same project.

1. iOS with iPad running companion version 290-1.

Title and Description look fine. However, icons are not showing, defaulting to pins.

2. Android companion version 299 on all devices

Icons look fine. However, title and description cut off (Sony Experia) or jammed into a narrow column (LG K40)

Platform: Both Android and iOS

App developed with Snap to Place Have not yet tried to compile and load to see if the problem is in both companion and compiled.

Project Link

LMK privately if you need a link.

Community Link

N/A

  SCREENSHOTS

Ipad(1) sonyExperiaAndroid sonyXperia2android LGandroid

jaredgibb commented 2 years ago

Providing a project URL would be helpful. I can confirm this on my side and will escalate this bug internally. We are also on a more updated version of the companion app for iOS so please do update that. :)

KaneoheKid commented 2 years ago

Thanks again for including the icons. My project is below. https://x.thunkable.com/copy/01f5609202983c9016236e6afe69acda

As I mentioned, the display in the popup is very inconsistent between different smartphones. Sometimes a tall column with all of the title/description words and other times wide with just the first one or two.

don

On Wed, Dec 29, 2021 at 7:05 AM jaredgibb @.***> wrote:

Providing a project URL would be helpful. I can confirm this on my side and will escalate this bug internally.

— Reply to this email directly, view it on GitHub https://github.com/thunkable/thunkable-issues/issues/1088#issuecomment-1002691959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDXAC55O3D53TJGDWWKPJ3UTM5WDANCNFSM5K5PCJFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

KaneoheKid commented 2 years ago

PS. In order to get to the map, you must first register using the password @.*** . Then, select a "mission" and let it load. Depending on the phone or tablet, it might take a minute or so. Then, tap on the MAP" button or select "Mission Map" from the sidebar. Again, it can take up to a minute to render the map if the device is slow or you choose one of the larger missions.

don

On Wed, Dec 29, 2021 at 11:29 AM Don Schlack @.***> wrote:

Thanks again for including the icons. My project is below. https://x.thunkable.com/copy/01f5609202983c9016236e6afe69acda

As I mentioned, the display in the popup is very inconsistent between different smartphones. Sometimes a tall column with all of the title/description words and other times wide with just the first one or two.

don

On Wed, Dec 29, 2021 at 7:05 AM jaredgibb @.***> wrote:

Providing a project URL would be helpful. I can confirm this on my side and will escalate this bug internally.

— Reply to this email directly, view it on GitHub https://github.com/thunkable/thunkable-issues/issues/1088#issuecomment-1002691959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDXAC55O3D53TJGDWWKPJ3UTM5WDANCNFSM5K5PCJFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

KaneoheKid commented 2 years ago

Following up. Attached is a screenshot on the LG phone using the old (single icon) map which shows the caption for same icon as in screenshot #2 above. Title and description are appropriate. I also checked a Android compiled version of this project and found that it has the same problem with the caption as described above. Screenshot_20211230-165747

kezb765 commented 2 years ago

I found another bug in using icons as markers: in my case the icons are always positioned several pixels to the left. As far as I can see it is always the same amount of pixels (not the same distance in lat/long). The following screenshot shows my test app: I draw 10 lines (yellow) from the actual position in random directions. At the end of each line I set a marker with "call Map1 with addIconMarker", this is an icon from the material icons lib, a black heart in 3636pixels. The resulting map works: when I press a position, where the icon should* be, I get the correct response in lat/long and (as you can see) also Title + Subtitle.

I get the same error in Drag&Drop mode and in the "old" mode, I see it in live testing and also in downloaded app. iOS or Android makes no difference.

BTW: (this is maybe another topic): the event "on CalloutPress" on Map1 does not work neither in iOS nor in Android.

2022-02-20 15-37-17-0

KaneoheKid commented 2 years ago

Confirming that I see the mislocation issue when working on my Androids too (Companion 30304 and download). I noticed it a few weeks ago but thought that it was just a transitory issue.

This seems to be a problem with the ADD ICON MARKER block. The simple ADD MARKER blocks place the icon in the correct position as demonstrated in this sample project:

https://x.thunkable.com/copy/8c7084463b8b52196b1266af1fcbdc46

However, it does not exhibit the same problem with the iOS companion, version 303-5. On my iPad, the icon markers are properly positioned but sometimes they are ovelapped with pins. ???

ioull commented 2 years ago

This seems to be a problem with the ADD ICON MARKER block. The simple ADD MARKER blocks place the icon in the correct position as demonstrated in this sample project:

I have exactly the same issue, regarding the eventual root cause of it it could be missing iconAnchor parameters ... However it could be interressant to add iconAnchor position as parameter so we can use centered icon for example or centeredbottom as it is per default with the default Marker.

ioull commented 2 years ago

Here is my code to put the 2 icons at the same place with addMarker or AddIconMarker : image

And the result when zooming on the map : image Screenshot_20220721-095530

It really seems to be an issue with the anchor as both icon keep connected ...