thunkable / thunkable-issues

24 stars 9 forks source link

Notification service extension for IOS Push Notifications #759

Open danibarzo opened 3 years ago

danibarzo commented 3 years ago

The notification service extention setup is required from IOS platform in order you can show an image when using Push Notifications feature

Would be nice if thunkable can have a procedure to setup the notification service extention without using a Mac with a new version of Xcode which is a requirement now. Just as the procedure Thunkable already have to publish IOS APPs (using only a Windows PC)

**this is needed only for IOS

Thanks in advance!

MrMazzone commented 3 years ago

Is this with OneSignal? I did notice that iOS users cannot receive the image in the notification. Is that what you are referring to?

danibarzo commented 3 years ago

With OneSignal and Yes, that is exactly what i am talking about @MrMazzone.

danibarzo commented 3 years ago

According with OneSignal support guys not seeing the Images on iOS notifications generally happens when the Notification Service Extension for your app is not setup, or is not set up correctly. I don't understand how to setup but this is the guide that OneSignal has: https://documentation.onesignal.com/docs/ios-sdk-setup. And one requirement is A Mac with a new version of Xcode.

MrMazzone commented 3 years ago

@danibarzo interesting. Yes, I would love this fixed too!

josmas commented 3 years ago

hi @danibarzo and @MrMazzone thanks for the report and added info. I am not sure if this is a limitation for iOS; we do all the configuration in that link for all apps, so there should not be a need to have a mac and xcode (we do that already) but it might be possible that the step to setup images correctly can only be done on a one app at a time basis, in which case we won't be able to do it. I'll have a go at it in any case and report back, although most likely not until some time late next week (or even the one after because of the holidays). Thanks!

danibarzo commented 3 years ago

Hi Joss, currently this setup is not covered by thunkable so please help us with a solution, you know one push notification without an image is like nothing..

On Fri, Dec 18, 2020, 11:17 AM Jos notifications@github.com wrote:

hi @danibarzo https://github.com/danibarzo and @MrMazzone https://github.com/MrMazzone thanks for the report and added info. I am not sure if this is a limitation for iOS; we do all the configuration in that link for all apps, so there should not be a need to have a mac and xcode (we do that already) but it might be possible that the step to setup images correctly can only be done on a one app at a time basis, in which case we won't be able to do it. I'll have a go at it in any case and report back, although most likely not until some time late next week (or even the one after because of the holidays). Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thunkable/thunkable-issues/issues/759#issuecomment-748182833, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQIBPRWVUVOXVHBLPZCSSTTSVN6ABANCNFSM4UJMI4KQ .

danibarzo commented 3 years ago

Hi @josmas, please have you checked this issue?. Thanks in advance!

josmas commented 3 years ago

It is on my TODO list for this week; hopefully I can get to it. Thanks!

danibarzo commented 3 years ago

Great, thanks!

On Mon, Jan 25, 2021 at 11:25 AM Jos notifications@github.com wrote:

It is on my TODO list for this week; hopefully I can get to it. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thunkable/thunkable-issues/issues/759#issuecomment-766935621, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQIBPRUT6CEO37LTL5APGXDS3WLODANCNFSM4UJMI4KQ .

josmas commented 3 years ago

Just as a heads up; we couldn't find anything wrong with the configuration of the module, so we are going to do a full upgrade as we are a couple of versions behind. The upgrade has not been scheduled yet though. Thanks!

danibarzo commented 3 years ago

Hi Jos, what do you mean?. I am testing and none iPhone receives the image attached with the push notification (having set the push notification feature with thunkable of course), only arrives the text. Have you tested it?

On Fri, Jan 29, 2021 at 7:58 AM Jos notifications@github.com wrote:

Just as a heads up; we couldn't find anything wrong with the configuration of the module, so we are going to do a full upgrade as we are a couple of versions behind. The upgrade has not been scheduled yet though. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thunkable/thunkable-issues/issues/759#issuecomment-769790170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQIBPRSGRAHGQD3H7UMMSZ3S4KWIJANCNFSM4UJMI4KQ .

josmas commented 3 years ago

We can see that it fails, but our config follows the docs so we don't know why it fails. We will do a full upgrade of the library to see if the problem is in the library itself. Does that make sense?

danibarzo commented 3 years ago

Yes of course, i am just thinking when i followed the steps to set up the Push notification feature in thunkable, the documentation never mentioned the "Notification service extension" which is actually a requirement to use images with this feature on IOS platform. But thanks for your reply and explanation, i hope we can use the complete feature soon.

josmas commented 3 years ago

Yes, we do that config on our side. In the same way that you only have to select a platform but not install the SDK for that platform. We hide as much stuff as possible to make it simpler, although with Apple not a lot of things are simple (with certs and so forth).

danibarzo commented 3 years ago

ok thanks, clearer. I'll be waiting for the full upgrade of the library.

danibarzo commented 3 years ago

Hi dear @josmas. Do you have any update about this issue?. Thanks in advance!

josmas commented 3 years ago

Still hasn't been scheduled, unfortunately.

danibarzo commented 3 years ago

Hi dear @josmas. Do you have any update about this issue?. Thanks in advance!

danibarzo commented 3 years ago

Hi dear @josmas . any update with this issue? at the moment images continue not arriving to IOS devices. Thanks!

josmas commented 3 years ago

Hi @danibarzo, apologies for the late reply. Are you having any other issues with notifications? We have just one report saying that notifications are not working on iOS, but it seems to be isolated.

danibarzo commented 3 years ago

hi @josmas . Yes, actually i have checked notifications are not working on IOS but i think this is an isolated case from the images issue.

josmas commented 3 years ago

Hi @danibarzo yes, they are independent, but can you confirm none of your iOS notifications work? We are having some issues determining if this is happening to everyone or just a few users.

danibarzo commented 3 years ago

i realized the las friday that notifications didnt arrived to my iPhone i use for test the APPs. i checked in OneSignal these two issues but i dont know if they are related:

image image

So i followed the OneSignal suggestion and generated a new .p12 certificate. Now i am waiting that Apple Store publish my new APP version, after that i will be able to test if the notifications arrive or the issue remains.

MrMazzone commented 3 years ago

@josmas My iOS notification are working as of this morning. However, I still have the image issue.

weihuali0509 commented 3 years ago

@MrMazzone is yours a recent new built/published? within a week?

MrMazzone commented 3 years ago

@weihuali0509 Build was maybe two to three weeks ago. So probably a pretty recent break.

josmas commented 3 years ago

thanks @danibarzo and @MrMazzone that is very helpful. We are also waiting here for test apps to fully determine the cause. Thanks!

weihuali0509 commented 3 years ago

@MrMazzone can you please publish again and see if you have the APN issue?

danibarzo commented 3 years ago

Thank you @josmas @weihuali0509 . Please let us know if you find what is happening.

MrMazzone commented 3 years ago

@weihuali0509 Sure. This error shows in OneSignal? Some directions to reproduce would be helpful.

danibarzo commented 3 years ago

hi @MrMazzone i got the errors from OneSignal (the prints i sent). Now you just please puplish your APP again and try to send a push notification, then if you dont recieve the Notification on your IOS device check in OneSignal if you have this similar issue in the user:

image

MrMazzone commented 3 years ago

@josmas @weihuali0509 I am getting the same error for my build from today. Users on old build successfully received notification. image

danibarzo commented 3 years ago

hi @weihuali0509 , do you have any update about this issue?. Thanks in advance!

danibarzo commented 3 years ago

hi @weihuali0509 , do you have any update about why the push notifications are not arriving to IOS devices?. Thanks!

weihuali0509 commented 3 years ago

The push notification should be fixed in iOS now.

weihuali0509 commented 3 years ago

We are still evaluating the notification service extension.

danibarzo commented 3 years ago

thanks @weihuali0509, please let us know when you solve the Notification Service Extension issue, you know a push notification with an image is great.

danibarzo commented 3 years ago

hi @weihuali0509, please how about the Notification Service Extension issue, have you check it?. Thanks in advace!

danibarzo commented 3 years ago

hi @weihuali0509, do you have any update about the Notification Service Extension issue?. Thanks!