search

thunkware / virtual-threads-bridge

Use Java21's Virtual Threads API in Java 8+
MIT License
8 stars 3 forks source link

Fix typo in "SempahoreExecutor" #24

Closed juliojgd closed 3 months ago

juliojgd commented 3 months ago

https://github.com/thunkware/virtual-threads-bridge/blob/096fa0f06164fb2bacb3933636c09b70cc3d96bf/src/main/java/io/github/thunkware/vt/bridge/SempahoreExecutor.java#L18

My proposal is to deprecate the class "SempahoreExecutor.java" (due to the typo in its name) in favor of "SemaphoreExecutor.java"

I would perform these steps:

  1. Create "SemaphoreExecutor.java"
  2. Move all the working code to the newly created class
  3. Delegate all calls in "SempahoreExecutor.java" methods to the corresponding methods in "SemaphoreExecutor.java"
  4. Mark "SempahoreExecutor.java" as deprecated for removal

The intention is not making a breaking change.

If you think it makes sense I can try to contribute a PR.

Thanks in advance

maxxedev commented 3 months ago

I would

  1. Create SemaphoreExecutor.java
  2. Modify SempahoreExecutor.java to subclass SemaphoreExecutor.java
  3. Mark "SempahoreExecutor.java" as deprecated for removal
maxxedev commented 3 months ago

Yes, if you can contribute a PR, that'd be great.