thunlp / EntityDuetNeuralRanking

Entity-Duet Neural Ranking Model
MIT License
153 stars 20 forks source link

Improve model code readability #8

Closed pommedeterresautee closed 4 years ago

pommedeterresautee commented 6 years ago

Little thing: code starting here can easily be replaced by a nested loop: https://github.com/thunlp/EntityDuetNeuralRanking/blob/7bbac77c74aa7af20fcce64aae53d44a2c72e6d5/baselines/CKNRM.py#L90

Helps to read and understand the purpose (and easily try with more CNN)