search

thunlp / NRE

Neural Relation Extraction, including CNN, PCNN, CNN+ATT, PCNN+ATT
MIT License
809 stars 309 forks source link

about test.h in CNN+ATT #36

Open ShellingFord221 opened 4 years ago

ShellingFord221 commented 4 years ago

Hi, in /CNN+ATT/test.h, line 114, it seems that the function vector<double> test(int *sentence, int *testPositionE1, int *testPositionE2, int len, float *r) is never used, since vector<double> score is never used in the following codes.

Therefore, * r, which should represent sentence encoding in function vector<double> test(int *sentence, int *testPositionE1, int *testPositionE2, int len, float *r), now is a random vector in void* testMode(void *id ) and is then pushed into r_tmp.

Did I miss something? Thanks!

JianJianHeng commented 3 years ago

*r is not a random vector，it was computed on vector<double> test(...).And i also found vector<double> score is never used.

revo1111 commented 1 year ago

1