thuryn / your-local-weather

Weather app for Android
GNU General Public License v3.0
131 stars 35 forks source link

Status bar icon style "Temperature" incorrect #107

Open infinitewaveparticle opened 5 years ago

infinitewaveparticle commented 5 years ago

Under Notification Settings, after switching the "Status bar icon style" to "Temperature" it displays the Celsius temperature instead of Fahrenheit even though I've selected to display F instead of C.

infinitewaveparticle commented 5 years ago

It also seems to display the current system time instead of the last updated time. Perhaps there should be an option to toggle this. I would prefer to see the last updated time so I know it is working.

thuryn commented 5 years ago

I've fixed the issue with the temperature unit. But I connot reproduct the problem with the time. Which update period do you use? What kind of notification?

infinitewaveparticle commented 5 years ago

@thuryn It seems to be ok now, but the updated time changes even when the update fails. When the update fails the "last updated time" should display the last time it actually succeeded.

thuryn commented 5 years ago

I see, I can imagine that there could be two approaches when time is updated: 1) whenever an attempt to update has been made (currently implemented) 2) when a successful update has been made

So to satisfy all users there should be an option to switch.

BeeeWall commented 5 years ago

Temperature icon is still inaccurate for me, although a bit of a different issue. When °C is selected, it seems to work fine, but when °F is selected the icon always shows 50, not the actual temp.

Log

(Not sure if I should create a separate issue or if this one is close enough, I'll create a new one if you'd prefer)

thuryn commented 5 years ago

I see, I'll check it. Sorry for the inconvenience.

  1. října 2019 1:33:56 SELČ, BeeWall notifications@github.com napsal:

    Temperature icon is still inaccurate for me, although a bit of a different issue. When °C is selected, it seems to work fine, but when °F is selected the icon always shows 50, not the actual temp. >

    Log>

    (Not sure if I should create a separate issue or if this one is close enough, I'll create a new one if you'd prefer)>

    -- > You are receiving this because you were mentioned.> Reply to this email directly or view it on GitHub:> https://github.com/thuryn/your-local-weather/issues/107#issuecomment-538591725

-- Odesláno aplikací K-9 Mail ze systému Android. Omluvte prosím moji stručnost.

thuryn commented 4 years ago

I've just tried to switch to F and icon works fine for me. I've found another bug related to forecast icons in a widget, but notification icon show correct value. Could you, please, send me a screenshot and the device type?

BeeeWall commented 4 years ago

It works now, odd. Wonder why it works now and not before. Not complaining though. Wonder if either there's been an update since that unintentionally fixed it, or if it's an issue with a specific temperature range. I'll try and remember to pay attention and see if anything makes it break.