thusser / spexxy

spexxy spectrum fitting framework
Other
4 stars 1 forks source link

Issue when convolving with empirical LSF #20

Closed skamann closed 2 months ago

skamann commented 2 years ago

https://github.com/thusser/spexxy/blob/14a8d121076b9e043bdf2e27222a65088f771ff9/spexxy/data/lsf.py#L489

The line should be changed to if self.crval2 > 0: - Because self.crval1 refers to the sampling of the LSF at a given wavelength, which is centred on zero, this condition is probably never fulfilled. So even if the LSF changes with wavelength, only a constant LSF is used.

thusser commented 2 months ago

Already fixed