thusser / spexxy

spexxy spectrum fitting framework
Other
4 stars 1 forks source link

Spectrum.redshift() returns wrong result for log10-sampled spectra #25

Closed skamann closed 2 months ago

skamann commented 1 year ago

Should expand if clause:

        if self._wave_mode == PyCrocoSpectrum.Mode.LAMBDA:
            # wavelength in AA means a multiplication
            self._wavelength = self.wave * (1. + vrad / 299792.458)
            # and non-constant step size
            self._wave_step = 0
        elif self._wave_mode == PyCrocoSpectrum.Mode.LOGLAMBDA:
            # wavelength in log domain is simpler
            self._wavelength = self.wave + math.log(1. + vrad / 299792.458)
            self._wave_start = self._wavelength[0]
        elif self._wave_mode == Spectrum.Mode.LOG10LAMBDA:
            self._wavelength = self.wave + math.log10(1. + vrad / 299792.458)
            self._wave_start = self._wavelength[0]
        else:
            raise NotImplementedError('Unsupported wave mode: {}'.format(self._wave_mode))
thusser commented 2 months ago

PyCroco? ;-)