search

thustorage / pacman

Pacman: An Efficient Compaction Approach for Log-Structured Key-Value Store on Persistent Memory
https://www.usenix.org/conference/atc22/presentation/wang-jing
43 stars 11 forks source link

Get operations return false when LOG_BATCHING option is enabled #5

Closed SeKwonLee closed 1 year ago

SeKwonLee commented 1 year ago

Hello,

I am testing KVSs (FlatStore-H) now. But, I found get operations return false when LOG_BATCHING option is enabled. The tested workload is YCSB Run C (Read only) using the eval_ycsb.sh script.

Could you check this and let me know if I missed something?

Thanks, Sekwon

starkwj commented 1 year ago

Hi Sekwon,

Sorry that the benchmark didn't drain the batching buffer and update those kv in the index after preloading. I have fixed that with https://github.com/thustorage/pacman/commit/fc5243f829c79e6e873b4bc38cf16bf51d35f73d . Please check if this helps.

Thanks.

SeKwonLee commented 1 year ago

Thank you for the quick reply! After the update, it is solved :)