search

thuva4 / Algorithms

Collection of algorithms in multiple programming languages.
https://thuva4.github.io/Algorithms/
Apache License 2.0
486 stars 545 forks source link

Improved UX and GitHub Pages #840

Closed jonasbn closed 3 years ago

jonasbn commented 3 years ago

Hi @Thuva4

I fell over your repository quite some time ago and even contributed to the Perl section.

I do however find the matrix navigation a bit annoying. I have been experimenting with adding JavaScript to websites based on GitHub repositories, extending the capabilities of the basic GitHub pages implementation and at the same time I challenge myself with small JavaScript tasks to help me learn JavaScript.

So this is not so much a PR as it is a suggestion for a new direction for your repository.

The PR requires GitHub pages are enabled. I have enabled GitHub pages for my own fork and pointed it too my branch with the contents of the PR, so you can see a live version of the proposed GitHub implementation here.

Let me know if you find this interesting, if you have any questions or anything. If you decide this is not what you had envisioned for this repository, there will be no hard feelings. Do note I am a JavaScript n00b, so my JavaScript code might need a review.

If you want to read more about my GitHub pages experiments please see my blog posts on dev.to:

thuva4 commented 3 years ago

Great, Thank you.

jonasbn commented 3 years ago

Hi @Thuva4

Heh, I thought you would request some changes or had some feedback.

https://thuva4.github.io/Algorithms/ looks great, but I think there is room for improvement, please let me know if there is anything your want be to have a look at.

For example, should we add a border to the matrix?

Take care and stay safe