search

thxprotocol / modules-solidity

Default Asset Pools are connected to an ERC20 contract. The pool is controlled by a permissioned (OAuth2.0) REST API which is responsible for paying the gas costs used to manage the pool. Access to the pool is managed with a flexible role-based access mechanism. Pools can hold various reward configurations for the connected ERC20 tokent contract and will manage the distribution of those token rewards with a withdrawal system. The poll system used to govern the reward configuration and withdrawals is optional.
4 stars 3 forks source link

Remove UpdateDiamond #23

Closed bram-rongen closed 2 years ago

bram-rongen commented 2 years ago

Since diamond update functionality is already in diamondCut here: https://github.com/mudgen/diamond-2/blob/master/contracts/facets/DiamondCutFacet.sol

peterpolman commented 2 years ago

@bram-rongen Might cause issues during local deploy since the order of deploys determines the addresses of the facets. Maybe combine it with moving the facet addresses in this package? Then we can publish that package and API will only have to update and read the config from it.

peterpolman commented 2 years ago

Nevermind, just noticed your changes to the deploy script. Should be fine for local deploys! Moving facet config for prod/dev in the package can be done later.