thxprotocol / modules-solidity

Default Asset Pools are connected to an ERC20 contract. The pool is controlled by a permissioned (OAuth2.0) REST API which is responsible for paying the gas costs used to manage the pool. Access to the pool is managed with a flexible role-based access mechanism. Pools can hold various reward configurations for the connected ERC20 tokent contract and will manage the distribution of those token rewards with a withdrawal system. The poll system used to govern the reward configuration and withdrawals is optional.
4 stars 3 forks source link

Provide _createWithdrawPoll() alternative for 06-Reward implementation #6

Closed peterpolman closed 2 years ago

peterpolman commented 3 years ago

Facets 05-Withdraw and 06-Reward share storage and implement identical _createWithdrawPoll() functions, which compromises code modularity of the Diamond Standard.

peterpolman commented 2 years ago

Since we deprecated use of the reward layer this should no longer be an issue.