search

thybag / PJAX-Standalone

A standalone implementation of Pushstate AJAX, for non-jquery webpages.
203 stars 42 forks source link

'pjax:end' event #43

Open staabm opened 6 years ago

staabm commented 6 years ago

does this lib intentionally not support the pjax:end which the origin lib does?

thybag commented 6 years ago

Ahoy,

Not intentionally at least - I've not had a chance to really look at this lib in quite some time, so its now potentially a few years behind jquery-pjax, and may well be missed some of the newer features.

Although it tries to do same job, it is also a totally different codebase/implementation so does do some things very differently to jquery-pjax.

In this case i suspect the complete event will probably do what you want, as it fires after the HTML on the current page has been updated etc

staabm commented 6 years ago

thx for your answer.

the original lib supports complete and end, see https://github.com/defunkt/jquery-pjax#events

would you support changes to this lib which renders it more in-line with the upstream? or wouldn't you accept those changes because of BC concerns?

thybag commented 6 years ago

If your happy to do a PR, i have no objection to there being an end event etc.