thygate / stable-diffusion-webui-depthmap-script

High Resolution Depth Maps for Stable Diffusion WebUI
MIT License
1.72k stars 159 forks source link

Do we have plan to integrate DepthPro model? #475

Closed tufeixp closed 1 month ago

tufeixp commented 1 month ago

https://huggingface.co/apple/DepthPro

https://github.com/spacepxl/ComfyUI-Depth-Pro

graemeniedermayer commented 1 month ago

hmm I was concerned about the weird licenses. Are both the licenses to avoid liability?

tufeixp commented 1 month ago

hmm I was concerned about the weird licenses. Are both the licenses to avoid liability?

Looks fine: https://developer.apple.com/support/downloads/terms/apple-sample-code/Apple-Sample-Code-License.pdf

graemeniedermayer commented 1 month ago

So there's some difficult with integration because it uses an older version of timm so it breaks other models.

I made a branch that includes it here https://github.com/graemeniedermayer/stable-diffusion-webui-normalmap-script/tree/depthpro

For my usage, it actually doesn't seem an improvement over high resolution depthanything v2 (depthanything v2 left, depthpro right) comparison