search

thygesteffensen / PowerAutomateMockUp

Skeleton to run Power Automate Flows from their JSON descriptions.
MIT License
7 stars 1 forks source link

ActionResult does not handle errors messages #1

Closed thygesteffensen closed 3 years ago

thygesteffensen commented 3 years ago

When using PAMU to implement connectors, the current structure can't handle errors correctly. Errors should be piggybacked back to the engine, which should handle the error, such that if the action is inside a scope, it will be handled recordingly.

Suggestion: Either implement an exception field on ActionResult or string error message field, to enable piggybacking of errors from Connectors back to engines, as they were the real deal.

thygesteffensen commented 3 years ago

This have been implemented. ActionResult have been extended to support an exception.

If an Action Executor logic catches an exception, the status should be failed and the exception is added to the ActionResult object.

If the flow runner cannot find an action to run, after the current AE with status failed, the exception is thrown, from the Flow Runner.

IF an action depend on the failing action and is set to run on status failed, the exception should not be thrown, since the flow might handle such an error.

It is up to the AE implementer, to determine which exception is added to the ActionResult and which exception that are thrown from the AE.