search

thymeleaf / thymeleaf-docs

Thymeleaf documentation
Apache License 2.0
44 stars 54 forks source link

The last use of .build() to render the uri... #27

Closed josejuanmontiel closed 8 years ago

josejuanmontiel commented 9 years ago

Hi,

when i follow the docs (12.1 Building URIs to controllers) to build uri... instead of url, show a class name... it takes me one our to realize that (following docs http://docs.spring.io/spring-framework/docs/4.1.2.RELEASE/spring-framework-reference/html/mvc.html#mvc-links-to-controllers-from-views) that may .build() was missing.

I modify the docs to show this... and change method controller to return "String" because its thymeleaf+spring, and thinks its more clear.

And put an example without params (may you can delete this).

The important ;) the missing .build() ¿i'm wrong?

Thanks.

danielfernandez commented 8 years ago

Sorry for the long delay.

You are right, there's a .build() missing there. Thanks so much.

Now in order to merge your pull request I would need you to carefully read our Contributor Terms and Conditions and explicitly agree to what is explained there (a comment here will suffice): https://github.com/thymeleaf/thymeleaf-docs/blob/bb823688283512a3643a882e63d7101ddaee8e83/CONTRIBUTING.markdown

josejuanmontiel commented 8 years ago

Ok, no problem. I accept the terms and conditions.

danielfernandez commented 8 years ago

Merged. Thanks!