search

thymeleaf / thymeleaf-docs

Thymeleaf documentation
Apache License 2.0
44 stars 54 forks source link

Thymeleaf 3.0 #42

Closed kolorobot closed 7 years ago

kolorobot commented 7 years ago

Ready for review version of Layouts article.

ultraq commented 7 years ago

Ah, can't believe I missed this! The changes look good, and we should really get these into the docs so we have an updated article on layouts 👍

@danielfernandez?

danielfernandez commented 7 years ago

It's entirely my fault. When @kolorobot did this changes, which I asked him for, I was in the middle of the (quite complex) integrations for Spring 5 WebFlux, which were only completed a couple of weeks ago with the creation of the new SSE output mechanism.

Back in December I asked Rafał for a couple of weeks to have a look at these changes, and we are already in April, the notification for this pull request still living in my inbox with the TO-DO-NOW label applied. So by all means and laws he now has the full right to wholeheartedly hate me. I'm sorry 😳

Things are clearing up right now, though I still need to create an example application for the new WebFlux capacities before May comes, but I promise I will have a detailed look at this soon. Real soon this time. Sorry again.

danielfernandez commented 7 years ago

Merged! Thanks a lot Rafał! Please let me finish reviewing the PR for the app and I'll publish right away.