thymeleaf / thymeleaf-docs

Thymeleaf documentation
Apache License 2.0
44 stars 54 forks source link

Update gradle, build process #51

Closed ultraq closed 5 years ago

ultraq commented 7 years ago

Just having a look through this projects build.gradle file and I can see a few things that could do with updating/modernizing:

ultraq commented 7 years ago

I've added the gradle wrapper, tied to the last 2.x version since that's what this project was originally built for. Will still need to take some time to do the above to clean things up and then need to update the gradle wrapper accordingly.

danielfernandez commented 7 years ago

So, do I need to do any changes or make sure that anything is configured in some specific way at the releases machine?

By the way, the releases machine is now an Ubuntu Server... somehow Amazon EC2 decided to kill our old releases CentOS machine in a way that it was not possible to start it again, complaining there was no /boot filesystem. I changed nothing so I assume it was some configuration update in the distribution (which was from the marketplace, not a standard EC2 one) that made this during a yum update. Then I also discovered that the EBS volumes that are created for AMIs from the Marketplace can only be mounted (which I needed to do for recovery) on machines instantiated from the same AMI, which is extremely inconvenient IMHO... so I finally decided to rebuild the base system on a standard, non-marketplace Ubuntu Server (which is working great and has newer versions of almost everything) and then recover all data and releases setup from the CentOS one by means of creating a temporary one and moving things from the non-working CentOS volume to the Ubuntu one.

ultraq commented 7 years ago

You shouldn't have to change anything for building docs right now. The idea behind the gradle wrapper is so that the version of gradle a project was built for can be invoked for builds no matter the actual version of gradle on the machine. It was something I noticed when I upgraded my own machine to 4.x and then suddenly couldn't build this project because so many things had changed since 2.x!

danielfernandez commented 7 years ago

Ok, so I assume the way to call the build here has changed to ./gradlew?

Also, remember to merge dev into master when finished. I'll probably have to release a new version today or tomorrow (docs can wait a bit, anyway) hot on the heels of Spring 5.0.0.RC3 which should be released today and just before Spring Boot 2.0.0.M3 which should use our new version. If you want me to use the new system for the docs of the new version (for which, anyway, I can wait a couple of days), then merge and tell me. If not... I'll just use the old mechanism.

ultraq commented 7 years ago

Ok, so I assume the way to call the build here has changed to ./gradlew?

Yup :)

I'll merge that part to master soon after writing this, but the other stuff in this issue that I wanted to do to get things working w/ newer versions of gradle, I won't get around to starting that for several days, so don't worry about waiting on those.

ultraq commented 5 years ago

Over 1 year later, finally upgraded! 😅 See #68 for details.