Support Tiles 3 - Githubissues

thymeleaf / thymeleaf-extras-tiles2

Thymeleaf integration with Apache Tiles 2.x

http://www.thymeleaf.org

36 stars 18 forks source link

Support Tiles 3 #24

Open rwinch opened 8 years ago

rwinch commented 8 years ago

Spring Framework's latest SNAPSHOT has removed Tiles 2 support (which has been deprecated for some time). It would be great to get support for Tiles 3.

See https://jira.spring.io/browse/SPR-13229

danielfernandez commented 8 years ago

Evaluating Tiles 3 support for (at least) Thymeleaf 3 is definitely in our plans, once we release 3.0 GA. This will probably mean a rewrite of the integration module, as the Tiles 3 architecture is completely different from that of Tiles 2.

rwinch commented 8 years ago

Any updates on this? Spring Framework 5 is getting close to completion and it has removed support for Tiles 2.

danielfernandez commented 8 years ago

Not yet :(. This is in the roadmap, but we haven't given it high priority so far given Thymeleaf 3.0 includes Fragment Expressions, which results in a much more flexible layout mechanism.

Anyway, as I said, evaluating Tiles 3 support is definitely in our roadmap still.

As for Spring 5, our current integration efforts are focused on providing support for using Thymeleaf as a reactive-friendly template engine (see section 10 in our migration guide and also this). But anyway, that is a completely different topic :)

ghost commented 7 years ago

Without Tiles 3 it's impossible to use spring social login and Thymeleaf 3. Forced to downgrade to Thymeleaf 2 :(

http://stackoverflow.com/questions/37229151/spring-boot-tilesdialect-throw-exception

danielfernandez commented 7 years ago

@serge-nikitin that would be indeed bad news. But, please, could you help me understand how the lack of Tiles 3 support affects Spring Social? Where's the specific dependency there?

ghost commented 7 years ago

@danielfernandez

Sorry, I can not show you exactly dependency, because I even don't know what is Tiles is and I'm totally not an expert in Spring Security.

But I made for you a simple spring boot project where you can see this problem by yourself. There is also a logfile with an error in the attaches files.

The error will disappear when you:

Change Thymeleaf version to 2
Or remove from the application.properties these lines:

spring.social.twitter.appId=****************************
spring.social.twitter.appSecret=****************************

spring_social_thymeleaf.txt t1.zip

danielfernandez commented 7 years ago

@serge-nikitin from your exception trace, your problem has nothing to do with Tiles or Spring Social. It is a dependency version compatibility issue. You were trying to use Thymeleaf 3 with a version of the Layout Dialect meant to be used with Thymeleaf 2.1.

ghost commented 7 years ago

@danielfernandez you are right, sorry for the confusion.

nicholas-os commented 7 years ago

Is this still on the roadmap? Tiles 3 support would be much appreciated.

danielfernandez commented 7 years ago

It is still on the roadmap, but unfortunately right now there are some other pressing priorities, and in Thymeleaf 3 the layout options are pretty well covered. It is true a lot of people are still familiar with Tiles and prefer to keep using it, so it is a good idea to have this, but… all I can say for now is "mid-term".

jesse1993 commented 6 years ago

Tiles 3 support would be much much appreciated.

helloworldtang commented 6 years ago

Tiles 3 with spring5 support would be much much appreciated.

froilson commented 10 months ago

2023 and still without news about Tiles 3 integration. Any update on this?