Open sakuna63 opened 2 years ago
SpringValueTagProcessor could pass null value as type parameter of RequestDataValueProcessor#processFieldValue although type is defined as Nonnull parameter（not annotated @Nullable）in spring-framework.
SpringValueTagProcessor
null
type
RequestDataValueProcessor#processFieldValue
@Nullable
https://github.com/thymeleaf/thymeleaf-spring/blob/3.1-master/thymeleaf-spring5/src/main/java/org/thymeleaf/spring5/processor/SpringValueTagProcessor.java#L103-L106
For example, when SpringValueTagProcessor process <option value="aaa">, type will be null (because option has no type attribute).
<option value="aaa">
option
In the scenario like above example, i think IElementTag#getElementCompleteName should be used as type value.
IElementTag#getElementCompleteName
I'll send small PR to fix this issue later. thaks.
SpringValueTagProcessorcould passnullvalue astypeparameter ofRequestDataValueProcessor#processFieldValuealthoughtypeis defined as Nonnull parameter（not annotated@Nullable）in spring-framework.https://github.com/thymeleaf/thymeleaf-spring/blob/3.1-master/thymeleaf-spring5/src/main/java/org/thymeleaf/spring5/processor/SpringValueTagProcessor.java#L103-L106
For example, when
SpringValueTagProcessorprocess<option value="aaa">,typewill benull(becauseoptionhas notypeattribute).In the scenario like above example, i think
IElementTag#getElementCompleteNameshould be used astypevalue.I'll send small PR to fix this issue later. thaks.