thymikee / jest-preset-angular

Jest configuration preset for Angular projects.
https://thymikee.github.io/jest-preset-angular/
MIT License
885 stars 306 forks source link

Angular: Jest without Zone (noNgZone). #354

Closed x47188 closed 18 hours ago

x47188 commented 4 years ago

Hey 🙌

I was wondering if there was any documented way to run Angular 9 + Jest without zone.js ( setupJest.ts heavily relies on Zone)?

wtho commented 4 years ago

Hey!

No, we just got into the first compatibility issues with Angular 9, so there's no work done on this field so far. But you can try removing these imports in your project and report your findings!

x47188 commented 4 years ago

Removing the zone imports will raise an In this configuration Angular requires Zone.js error at boot.

Some interesting findings:

ahnpnl commented 4 years ago

I remember I tried this before, with Angular 8 or lower I also got some similar errors so I gave up about excluding zone. Angular looks like tightly coupled with zone

wtho commented 4 years ago

@x47188 but if I interpret the issue right, you do have an app that runs without zone.js and you want to achieve the same in jsdom for jest, is that the case? Then I think we should look into it.

x47188 commented 4 years ago

but if I interpret the issue right, you do have an app that runs without zone.js and you want to achieve the same in jsdom for jest, is that the case?

Absolutely.

Then I think we should look into it.

Very appreciated!

However I fear the current TestBedRender3 implementation isn't flexible enough to allow ivy-only zonejs-less rendering.

wtho commented 4 years ago

Do your zoneless tests run in Karma?

x47188 commented 4 years ago

@wtho good question, I'll create a "repro" to verify that. (I've striped karma & co from my current code-base)

wtho commented 4 years ago

Thanks, if you could also share it, that would be awesome!

ahnpnl commented 3 years ago

I think this depends on the development from Angular to work without zone, which is currently in roadmap https://angular.io/guide/roadmap#leverage-full-framework-capabilities-with-zonejs-opt-out

igorzablotny commented 5 months ago

@ahnpnl Hi, since angular 18 features experimental zoneless support, is that planned for the near future? Right now in the application without zone, importing preset with import 'jest-preset-angular/setup-jest'; throws an error, since zone is not loaded in zoneless application.

Cannot find module 'zone.js' from 'node_modules/jest-preset-angular/setup-jest.js'
ahnpnl commented 5 months ago

Hi, yes I think if we can rely on a flag from angular package to detect when zone is available to import, it should be easy to implement into the existing setup file.

If there is no such flag, i think we might need a separate setup file for testing zoneless application.

PR is welcome :)

meierw commented 5 months ago

This currently is a blocker for us to start using Zoneless apps in Angular 18. Would love to see a fix :bow:

ahnpnl commented 5 months ago

You can simply copy the content of setup-jest.js and remove zone import.

meierw commented 5 months ago

Ok it was a bit of an ordeal that I had to go through. Cause I was using @angular-builders/jest.

Even though I understood from the docs that @angular-builders/jest merges it's config with the user config. I still couldn't get all the correct config values to work and overwrite the base config that @angular-builders/jest had under the hood.

In the end I completely ripped out @angular-builders/jest in favor of just using jest directly.

Now my jest config looks like this and works with provideExperimentalZonelessChangeDetection() everywhere. In my app config as well as in my TestBed providers.

// package.json
{  
  "jest": {
    "preset": "jest-preset-angular",
    "setupFilesAfterEnv": [
      "<rootDir>/jest.setup.ts"
    ]
  }
}
// jest.setup.ts
import { getTestBed } from "@angular/core/testing"
import {
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting,
} from "@angular/platform-browser-dynamic/testing"

const testEnvironmentOptions =
  (globalThis as any).ngJest?.testEnvironmentOptions ?? Object.create(null)

getTestBed().initTestEnvironment(
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting(),
  testEnvironmentOptions,
)

Thanks. @ahnpnl for the hint of just copying the setup code.

ahnpnl commented 5 months ago

Besides, I asked Angular team and they also suggested to include this https://github.com/angular/components/blob/04d3b63de2fb843beb55836e39e930c3342d26f1/test/angular-test-init-spec.ts#L35

I think in the next major release, we can provide function to call instead of implicitly calling setup TestBed upon import like current way.

Providing function call to setup Jest will be more flexible instead of relying on globalThis