thyrlian / AndroidSDK

🐳 Full-fledged Android SDK Docker Image
Apache License 2.0
1.25k stars 219 forks source link

[Improvement] Update Gradle and Kotlin version #56

Closed BreakDeveloper closed 3 years ago

BreakDeveloper commented 3 years ago

Hello @thyrlian ,

Could you update public version docker image Gradle version from 6.7 to 6.8.3 and Kotlin version from 1.4.10 to 1.5.0 ?

I know we can changed version locally but our devOps use public version and I don't have right to modified it

Please update

Thanks !

李先生您好!

請問方便更新一下目前公用的docker image嗎?

我們DevOps目前不採用客製化image且我也沒有權限可以進行修改

因此需要仰賴您的image更新

感謝 !

thyrlian commented 3 years ago

Hello @BreakDeveloper, many thanks for using this Docker image and as well submitting this request.

In fact, as stated in the README

Gradle and Kotlin compiler come together with this Docker image merely for the sake of convenience / trial.

In the long run, we'll phase them out eventually.

There are a thousand Hamlets in a thousand people's eyes. The same applies here - different project has different need of dependencies (and versions). In theory, there are infinite version combination possibilities of grouping Gradle and Kotlin compiler.

Actually, this problem has already been considered, that's why we've left flexibility of configuring dynamic version number for Gradle and Kotlin compiler. To use it, you just need to:

# or you can also pass specific tool version as you wish (optional, while there is default version)
docker build --build-arg JDK_VERSION=<jdk_version> --build-arg GRADLE_VERSION=<gradle_version> --build-arg KOTLIN_VERSION=<kotlin_version> --build-arg ANDROID_SDK_VERSION=<android_sdk_version> -t android-sdk android-sdk

If your company uses this Docker image, which is available on the public Docker registry, you can simply follow the above step to create and publish your own image to the public Docker registry and then start to consume it, not much effort.

Nevertheless, since Gradle and Kotlin compiler are still part of this bundle at the moment, I just updated their versions and dropped a new release, please check it out.

非常感謝您的使用,歡迎提出寶貴的意見! 祝好 😊