thyrlian / AndroidSDK

🐳 Full-fledged Android SDK Docker Image
Apache License 2.0
1.25k stars 219 forks source link

[Requirement] Upgrade AGP 8.x and JDK 17 #72

Closed Break4ever closed 1 year ago

Break4ever commented 1 year ago

I am using 'gradlew wrapper' change version to 8.1 but base on some reasons I don't have permission to control our team Jenkins CI such as build args so that I can not type '--build-arg JDK_VERSION=17'

And I think it's time to upgrade your base image because start in AGP 8.x.x, minimum JDK is 17, and you could also upgrade Kotlin version to 1.8.x

I know above requirement upgrading for you seems like period routine, but your image really helps me a lot.

Thanks @thyrlian

Break4ever commented 1 year ago

Currently in my Jenkins CI phase, the following script is my workaround:

sh "apt-get update -y"
sh "apt install openjdk-17-jdk -y"
sh "./gradlew wrapper --distribution-type=ALL --gradle-version=8.1 -Dorg.gradle.java.home=/usr/lib/jvm/java-17-openjdk-amd64 <build-your-app-args>

Although above script is worked, but seems like spend a lot of times for initial apt update and install JDK 17 when trigger CI every time

Please upgrade your base image.

Thanks

thyrlian commented 1 year ago

Hi @Break4ever, thank you for using the image.

Regarding your concern, there are two folds:

I'm going to merge this PR, so your requirement is fulfilled. I'll do a few more things and then publish the image.

Thanks a lot.