search

thyrlian / AndroidSDK

šŸ³ Full-fledged Android SDK Docker Image
Apache License 2.0
1.25k stars 219 forks source link

Upgrade To Latest Ubuntu LTS #78

Open mcmah309 opened 1 month ago

mcmah309 commented 1 month ago

Currently the image is built off ubuntu:22.04. This should be upgraded to the latest Ubuntu LTS ubuntu:24.04.

(Not a bug but unable to create another type of issue)

thyrlian commented 1 month ago

The current base image is ubuntu:22.04, and youā€™re suggesting an upgrade to ubuntu:24.04, I totally understand the point. Whilst both are LTS versions, with 22.04 supported until June 2027 and 24.04 until June 2029, I donā€™t see an urgent need to upgrade at this time.

The new version, 24.04, brings some changes, but for our use case, particularly in headless mode for Android building, there arenā€™t significant benefits (as far as I can see, but my knowledge for 24.04 is quite limited). Additionally, Iā€™ve experienced some issues with 24.04 on one of my personal computer, such as restrictions on unprivileged namespaces, which causes some issue to the Docker Desktop application.

However, we will eventually need to upgrade to the next LTS. Iā€™ll review the PR to see what can be done.

Thank you.

Please let me know if this addresses your concern.

mcmah309 commented 1 month ago

Packages keep going out of sync with requirements of other projects for us. It's starting to effect our development. We'd rather not fork if we can avoid it, but it's starting to become a necessity on our end.

thyrlian commented 1 month ago

Hi Henry, thank you for the explanation. Do you mind providing any examples (of packages/dependencies)? Thanks.

mcmah309 commented 1 month ago

Hello, thanks for the quick reply. We need cmake 3.26+, a few others like protoc and node, I don't recall those versions off the top of my head.

thyrlian commented 1 month ago

@mcmah309 please check all my comments in the PR, especially the last one, if you can help test that in your local machine with your Android project? Thanks in advance.

mcmah309 commented 1 month ago

I built the image locally, applied our dev environment on top, and ran a flutter/android app. I had to upgrade our gradle version (as expected) but other than that everything is working seamlessly :+1: