thyseus / yii-user-management

a user management module collection for the yii framework
186 stars 122 forks source link

E_STRICT Errors #157

Open soju22 opened 10 years ago

soju22 commented 10 years ago

Hello

Great module, but not compatible with strict PHP standards.

For example in YumTranslationController :

Declaration of YumTranslationController::performAjaxValidation() should be compatible with that of YumController::performAjaxValidation()

Function performAjaxValidation in YumTranslationController :

    protected function performAjaxValidation($model)
    {
        if(isset($_POST['ajax']) && $_POST['ajax']==='translation-form')
        {
            echo CActiveForm::validate($model);
            Yii::app()->end();
        }
    }

Should be (for example) :

    protected function performAjaxValidation($model, $form='translation-form')
    {
        parent::performAjaxValidation($model, $form);
    }

PS: I know E_STRICT error reporting can be disabled