thysultan / stylis

light – weight css preprocessor
https://stylis.js.org
MIT License
1.71k stars 82 forks source link

fix: webkit mask-composite values #309

Open Olivia-SY129 opened 1 year ago

Olivia-SY129 commented 1 year ago

Fix for mask-composite prop values for webkit

Here are the changes:

'add' → 'source-over'
'substract' → 'source-out'
'intersect' → 'source-in'
'exclude' → 'xor'

Example for element.return:

before fix (not working in webkit)
'-webkit-mask-composite: add,intersect;mask-composite: add,intersect;'  

after fix
'-webkit-mask-composite: source-over,source-in;mask-composite: add,intersect;'
thysultan commented 1 year ago

@Olivia-SY129 can you add a test case, i'm assuming we can replace replaceAll with just replace safe assumption?

coveralls commented 21 hours ago

Pull Request Test Coverage Report for Build a2068999eb1181efab0211ca5280abc7c776a87f-PR-309

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Prefixer.js 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Totals Coverage Status
Change from base Build bc0b1b03f5562eb8b38601e4e05461631a91c400: -0.3%
Covered Lines: 270
Relevant Lines: 273

💛 - Coveralls