search

thytom / dwmbar

A Modular Status Bar for dwm.
GNU General Public License v3.0
128 stars 23 forks source link

Problem with install.sh script #34

Closed anurag3301 closed 2 years ago

anurag3301 commented 2 years ago

Hey, I think there is a bug with the install script. This line to be precise. https://github.com/thytom/dwmbar/blob/574f5703c558a56bc9c354471543511255423dc7/install.sh#L36

If you have already run the install script, you make some changes to any module and wish to run the install script again. This is going to copy the entire module directory and place it in /usr/share/dwmbar/modules resulting in the creation of /usr/share/dwmbar/modules/modules where your updated modules are placed but are not used.

image

I fixed it by doing following

cp -r ./modules/* "/usr/share/dwmbar/modules"

Have a look at this and let me know if I did anything wrong or how it can be done in a better way. :)

thytom commented 2 years ago

Woah, I didn't realize people still used this :o

Your solution works if you've already installed dwmbar once before, but I just tested the change on a fresh installation and it fails to write the initial directory.

Changing the line to

 cp -rT "./modules" "/usr/share/dwmbar/modules"

Seems to fix the bug, so I'll push that change now.

You can also copy your modified modules to .config/dwmbar/modules/. and it should automatically override those in /usr/share next time you start dwmbar, if you're looking for an easier way to modify things.

If you come up with any cool modules or fixes/features, feel free to make a pull request, I'd be happy to merge any changes!