ti-community-infra / test-dev

012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
0 stars 8 forks source link

*: PoC to verify if the modification can take effect after approval #522

Open s3nt3 opened 2 years ago

s3nt3 commented 2 years ago

What problem does this PR solve?

Issue Number: ref #524

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

Side effects

Documentation

Release note

Please add a release note, or a 'None' if it is not needed.

Issue Number: ref #524

mini-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
mini-bot commented 2 years ago

Welcome @s3nt3! It looks like this is your first PR to ti-community-infra/test-dev 🎉

mini-bot commented 2 years ago

Hi @s3nt3. Thanks for your PR.

I'm waiting for a ti-community-infra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mini-bot commented 2 years ago

@s3nt3: Thanks for your contribution, but this is just a code repository for testing.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
s3nt3 commented 2 years ago

/cc @wuhuizuo

wuhuizuo commented 2 years ago

hold

wuhuizuo commented 2 years ago

/hold

wuhuizuo commented 2 years ago

/ok-to-test

wuhuizuo commented 2 years ago

/merge

mini-bot commented 2 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 8605cd3fb4f45d6e44a3c714903e10728c264177

mini-bot commented 2 years ago

Merge canceled because a new commit is pushed.

ti-chi-bot commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to sig-community-infra or Mini256. /lifecycle stale

ti-chi-bot commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Send feedback to sig-community-infra or Mini256. /lifecycle rotten

ghost commented 1 year ago

@s3nt3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
prow_debug 259af6b490ec7abbf484480fcca0b2a99508811c link true /test prow_debug

Full PR test history.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ti-chi-bot-dev[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s3nt3 Once this PR has been reviewed and has the lgtm label, please assign zuo-bot-2 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/ti-community-infra/test-dev/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot-dev[bot] commented 1 year ago

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary: The pull request includes 4 commits that mainly update the sample POC file. The POC file is added in the first commit and subsequently updated in the following three commits with new content.

Potential problems: It's difficult to determine any potential problems as there is no context provided about the overall purpose of this pull request, the intended functionality of the POC file, and whether there are any larger changes in the codebase that the POC may affect.

Fix suggestions: Without additional context, it's challenging to determine specific suggestions for fixes. However, it would be useful to include more information about the intended purpose of the POC file and any specific changes being made to the codebase that the POC will test. Additionally, ensure that the modified POC file does not affect any existing functionality or introduce any vulnerabilities.