search

tiaanduplessis / coinmarketcap-api

CoinMarketCap API wrapper for node
MIT License
121 stars 37 forks source link

feat(getIdMap): Add sort parameter #48

Closed cicoub13 closed 4 years ago

cicoub13 commented 4 years ago

Hello,

I've added a sort param in getIdMap. Feel free for any feedbacks.

cicoub13 commented 4 years ago

I think your CoinMarketCap API Key is expired

abhinavk99 commented 4 years ago

@tiaanduplessis Just wanted to let you know I replaced the API key in the Travis CI settings to my own to see if that would fix the tests.

Edit: DIdn't fix it for some reason 😕

abhinavk99 commented 4 years ago

Turns out you can't run tests from contributors that use environment variables to prevent security leaks. I'm going to download the branch locally and run the tests to make sure everything works, but I don't think your changes will break anything.

abhinavk99 commented 4 years ago

The tests all passed locally, so I'm merging. Thanks for the PR!

abhinavk99 commented 4 years ago

@tiaanduplessis I apologize since it says you're busy, but can you update the package on npm to the newest version (v3.1.0) whenever you're available?