search

tiaanduplessis / coinmarketcap-api

CoinMarketCap API wrapper for node
MIT License
121 stars 37 forks source link

v3.1.1 - Fixed error when an array of currencies is passed into getGlobal and added unit tests #54

Closed abhinavk99 closed 4 years ago

abhinavk99 commented 4 years ago

Fixes #53

Added unit tests to improve coverage to 100%

codecov[bot] commented 4 years ago

Codecov Report

Merging #54 into master will increase coverage by 20.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           master       #54       +/-   ##
============================================
+ Coverage   80.00%   100.00%   +20.00%     
============================================
  Files           1         1               
  Lines          45        47        +2     
  Branches       13        14        +1     
============================================
+ Hits           36        47       +11     
+ Misses          9         0        -9
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (+20.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad821da...145b532. Read the comment docs.

abhinavk99 commented 4 years ago

Also, can you update the library on npm to v3.1.1 after this gets merged in (assuming it's ready to merge)?

abhinavk99 commented 4 years ago

@tiaanduplessis Are you able to look at this sometime? If you're busy, no worries.

abhinavk99 commented 4 years ago

@tiaanduplessis Bumping again

tiaanduplessis commented 4 years ago

@abhinavk99 sorry, my notification inbox has been a mess. Will update to v3.1.1 shortly