search

tiagocoutinho / modbus-proxy

Connect multiple clients to modbus devices
Other
71 stars 13 forks source link

broken Dockerfile #14

Closed erikarenhill closed 2 years ago

erikarenhill commented 2 years ago

Description

It looks like the Dockerfile tries to copy modbus_proxy.py from the root folder when its actually placed under /src, modifying the Dockerfile to copy from /src/modbus_proxy.py instead makes the build to work but other issues trying to start the container as it can not find the modbus-proxy command that is specified as entry-point

What I Did

docker build --tag modbus-proxy .
Sending build context to Docker daemon  174.1kB
Step 1/7 : FROM python:3.8-alpine
3.8-alpine: Pulling from library/python
a0d0a0d46f8b: Pull complete
c11246b421be: Pull complete
5e6f9a3065f1: Pull complete
1d7a167f2660: Pull complete
0e99e6f9c94e: Pull complete
Digest: sha256:e11bbd37d4371894e954421b85dbe8dd4eb7198d7cb4ed144ab529f19f57c3f1
Status: Downloaded newer image for python:3.8-alpine
 ---> 9e170d41f428
Step 2/7 : WORKDIR /src
 ---> Running in 7ea8ce1ab12e
Removing intermediate container 7ea8ce1ab12e
 ---> e98c23a14127
Step 3/7 : COPY *.md modbus_proxy.py setup.py *.conf ./
COPY failed: file not found in build context or excluded by .dockerignore: stat modbus_proxy.py: file does not exist
tiagocoutinho commented 2 years ago

Confirmed. Thanks for reporting. Should be fixed by #15 which I just merged into master.