search

tiagocoutinho / modbus-proxy

Connect multiple clients to modbus devices
Other
71 stars 13 forks source link

Thank you! - and HomeAssistant Addon #18

Closed Akulatraxas closed 2 years ago

Akulatraxas commented 2 years ago

Just wanted to leave a thank you here for creating this. It was exactly what i needed. I am running homeassistant and a solaredge inverter. The Wallbox and the home assistant both want to talk to the inverter and this was impossible. I created a homeassistant addon (https://www.home-assistant.io/addons/) for this and was asked to make it public so others can use it as well .

Its the first time for me doing something like this and i am unsure how to attribute your work. I added a Mention and the Link back to this repository - is there a more appropriate way to do it?

https://github.com/Akulatraxas/ha-modbusproxy

ChristophCaina commented 2 years ago

thank you, @Akulatraxas Until last week, I had my SolarEdge Inverter integrated into HomeAssistant by using the SolarEdge Modbus Integration. Last week, I got a wallbox installed - so I had the exact same issue as you mentioned above.

Now, I found this modbus-proxy, which could solve the connection issues - but wasn't sure, if I can run it within the Addon "pyscript" for HomeAssistant - or if I should create a dedicated machine in my VM environment for this purpose.

Now, after seeing your comment - I can throw away all my concerns and could run your ha-modbusproxy instead :)

tiagocoutinho commented 2 years ago

Thank you for your kind words @Akulatraxas.

Thank you also for your concern in making sure proper credit is given to this project. Since I don't know home assistant and its addons/plugins system, I cannot comment on the details of your project. As far as I'm concerned, what you did concerning credit to my work is appropriate.